D18598: Defer initial positions apply until listing is complete

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, davidedmundson, chinmoyr.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This fixes the infamous "desktop positions partially scramble on reboot"
  bug that occurs when KDirLister completes listing in multiple model
  transactions.
  
  This also:
  
  - Disallows moves and drops while listing, for extra safety.
  - Cleans up wonky old defer-sometimes code that made little sense.
  - Removes a cache for lastRow() that was never actually used.
  
  BUG:354802

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190129/6cb0eef8/attachment-0001.html>