D18528: [Desktop Toolbox] Use a clearer name when the label is shown
Björn Feber
noreply at phabricator.kde.org
Fri Jan 25 15:41:18 GMT 2019
GB_2 added a comment.
Looks good!
INLINE COMMENTS
> ToolBoxButton.qml:30
>
> - property string text: main.Plasmoid.activityName
> + property string text: main.Plasmoid.activityName == i18n("Default") ? i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", main.Plasmoid.activityName)
> property bool isCorner: !buttonMouse.dragging &&
I think we should use this dash "—" instead of "-" for consistency.
REPOSITORY
R119 Plasma Desktop
BRANCH
desktop-toolbox-clearer-naming (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18528
To: ngraham, #vdg, #plasma, hein
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190125/7c437b51/attachment.html>
More information about the Plasma-devel
mailing list