D18528: [Desktop Toolbox] Use a clearer name when the label is shown

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When the Desktop Toolbox is dragged out of the corner, its label is shown. Currently this label is not very clear since it consists only of the name of the current activitym which by default is "Default".
  
  This patch introduces three changes:
  
  - When the label is shown, always prepend it with the widget's actual name: "Desktop Toolbox"
  - Append the word "Activity" so it's obvious what the preceeding string refers to
  - Don't show the activity name if it's "Default" since this signifies that the user does not use Activities and would be confused by seeing references to it

TEST PLAN
  There are no visible changes to the default appearance. The Desktop Toolbox still has no label when it's in a corner. When dragged out of the corner, here's how it looks with this patch:
  
  With the Default activity: F6567804: Desktop Toolbox, default activity <https://phabricator.kde.org/F6567804>
  
  With a differently-named activity: F6567805: Desktop toolbox, differently-named activity <https://phabricator.kde.org/F6567805>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  desktop-toolbox-clearer-naming (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18528

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190125/e9498f73/attachment.html>