D18471: [kcms/cursortheme] Fix size combo

Nathaniel Graham noreply at phabricator.kde.org
Wed Jan 23 14:58:16 GMT 2019


ngraham added a comment.


  Thanks, this fixes it, and the code change looks sane!
  
  While testing, I noticed that this combobox suffers from the same problem suffered by that the sub-pixel rendering combobox in the Fonts KCM: you can only close but pop-up by clicking on the button again: https://bugs.kde.org/show_bug.cgi?id=403403

INLINE COMMENTS

> kcmcursortheme.cpp:173
> +
> +    // we don't retrun early if m_selectedSizeRow == row as this is called after the model is changed
> +    m_selectedSizeRow = row;

retrun -> return

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18471

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190123/d4defbb7/attachment.html>


More information about the Plasma-devel mailing list