D18471: [kcms/cursortheme] Fix size combo
David Edmundson
noreply at phabricator.kde.org
Wed Jan 23 14:37:01 GMT 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
The biggest problem fixed was that m_preferredSize was sometimes treated as
an absolute value, sometimes as an index. This patch splits the two
concepts.
It also fixes the binding of the combobox to handle updates properly.
BUG: 403019
TEST PLAN
Clicked between themes
Closed and reopened the KCM had a valid value
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18471
AFFECTED FILES
kcms/cursortheme/kcmcursortheme.cpp
kcms/cursortheme/kcmcursortheme.h
kcms/cursortheme/package/contents/ui/main.qml
To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190123/fe27f344/attachment.html>
More information about the Plasma-devel
mailing list