D16212: [Device Notifier] Add a button to unmount all devices

Thomas Surrel noreply at phabricator.kde.org
Wed Jan 16 14:38:49 GMT 2019


thsurrel marked 6 inline comments as done.
thsurrel added inline comments.

INLINE COMMENTS

> broulik wrote in DeviceItem.qml:92
> Can we assume "action" is always unmount?

If the device is removable and mounted, than the action can only be unmounting, yes.

> broulik wrote in FullRepresentation.qml:113
> Why this change? `ColumnLayout` should layout everything automatically without the need for nachors

I do not manage to get the layout I want with ColumnLayout: I need to align that ScrollArea to the same level than the 'unmountAll' button

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/5f4fa6ac/attachment.html>


More information about the Plasma-devel mailing list