D16212: [Device Notifier] Add a button to unmount all devices

[Kai Uwe Broulik]

broulik added a comment.


  Looking good, please check again the layout change you didn't explain. Otherwise I think shis hould be good. Sorry for the long delay.

INLINE COMMENTS

> broulik wrote in FullRepresentation.qml:113
> Why this change? `ColumnLayout` should layout everything automatically without the need for nachors

Can you please investigate this change?

> devicenotifier.qml:122
> +                devicenotifier.connectedRemovables.push(source);
> +                devicenotifier.connectedRemovables = devicenotifier.connectedRemovables;
> +            }

This is for having the bindings refresh, right?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/c88fdf3c/attachment.html>