D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> virtualdesktopinfo.cpp:218
>      QStringList virtualDesktops;
> +    uint cachedDesktopLayoutRows = 0;
>      KWayland::Client::PlasmaVirtualDesktopManagement *virtualDesktopManagement = nullptr;

Would it be safer to assume there's 1 row until we update.

I'm sure we have some

columns = count / rows

code somewhere

> virtualdesktopinfo.cpp:293
> +
> +    QObject::connect(kwinServiceWatcher, &QDBusServiceWatcher::serviceRegistered,
> +        this, [this]() {

why?

If it's not registered it won't emit the signal anyway so there's no need to disconnect.
And the regular connect would persist regardless.

It would arguably make sense to re-query the initial state on service registration in case it changed whilst kwin was offline - but that's not what this does.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18290

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/fa8302e3/attachment-0001.html>