D18291: [Greeter] Ignore unwritable configuration files
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jan 16 09:14:10 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, graesslin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
When opening a non-writable config file, a `kdialog` process is spawned and the application waits for it to quit.
However, since in case of the lock screen, the input and everything is already blocked, the user cannot dismiss the warning generated by the greeter, effectively locking the user out.
BUG: 403255
TEST PLAN
Created a non-writable `~/.config/kscreenlocker_greetrc` and locked the screen:
Greeter comes up as normal
kscreenlocker itself may need something similar?
I grepped kde source code for that environment variable and it only seems to be used for warning suppression, it doesn't disable writing or persisting configuration.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D18291
AFFECTED FILES
greeter/main.cpp
To: broulik, #plasma, davidedmundson, graesslin
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/0f88f300/attachment.html>
More information about the Plasma-devel
mailing list