D17975: [Notifications] Add padding to notifications
Root
noreply at phabricator.kde.org
Fri Jan 11 12:24:06 GMT 2019
rooty added a comment.
You were right! Thank you so much, it was so much easier when I started thinking about it as a math problem rather than a design problem. I'm going to upload another diff, I hope this one stands up to scrutiny.
I apologize for the very long "implicitHeight" but it had to cover six different configurations:
- no icon + heading only
- no icon + heading + one line of body text
- no icon + heading + many lines of body text
- icon + heading only
- icon + heading + one line of body text
- icon + heading + many lines of body text.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D17975
To: rooty, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190111/0b8e448f/attachment.html>
More information about the Plasma-devel
mailing list