D17975: [Notifications] Add padding to notifications

[David Edmundson]

davidedmundson added a comment.


  You have 4 possible states:
  
  Icon is taller and text is one line
  Icon is taller and text is multi-line
  Text is taller and text is one line
  Text is taller and text is multi-line
  
  Changing font sizes is moving you between them, but that's just a side effect.
  
  ----
  
  You seem to be trying different things and then testing them. From this ever lasting history that's not working.
  
  Making margins match isn't a visual problem, it's a maths problem.
  
  When I reviewed this last time, I didn't run it, I just did it all on paper. (genuinely, here's a photo https://home.davidedmundson.co.uk/index.php/s/W8ZtPMZNyBAXRZz)
  
  Take a step back, do the calculations of the window height based on what things should be, and then it'll just work.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190111/7d457763/attachment.html>