D17975: [Notifications] Add padding to notifications

[Filip Fila]

filipf added a comment.


  In D17975#389769 <https://phabricator.kde.org/D17975#389769>, @rooty wrote:
  
  > In D17975#389760 <https://phabricator.kde.org/D17975#389760>, @filipf wrote:
  >
  > > FWIW if I backport the spacings and margins prior to D3560 <https://phabricator.kde.org/D3560> it works great for me. The symmetry around the icon is better than with this diff. (only NotificationItem.qml is modified)
  > >
  > > This diff:
  > >  F6537366: Screenshot_20190109_000448.png <https://phabricator.kde.org/F6537366>
  > >
  > > Old:
  > >  F6537364: image.png <https://phabricator.kde.org/F6537364>
  >
  >
  > Try rolling back NotificationPopup.qml too. They should look very similar to the ones in this patch. (The idea is that the notification in the second screenshot has padding only because arc-kde provides it.)
  
  
  Still better with the old values:
  
  F6537395: Screenshot_20190109_124600.png <https://phabricator.kde.org/F6537395>
  
  F6537396: Screenshot_20190109_124634.png <https://phabricator.kde.org/F6537396>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190109/c5d68555/attachment-0001.html>