D17975: [WIP, Notifications] Add padding to notifications

[Andres Betts]

abetts added a comment.


  In D17975#388981 <https://phabricator.kde.org/D17975#388981>, @filipf wrote:
  
  > I have some concerns about this. Mostly it's about visual consistency and notifications having different padding than other plasmoids. Notice how there's currently more or less equal distance to the left of Audio Volume and to the left of the album cover icon?
  >
  > F6535430: Screenshot_20190108_133709.png <https://phabricator.kde.org/F6535430>
  >
  > Wouldn't it be better to somehow add padding globally?
  >
  > Plus, some desktop themes already add padding, which would make their notifications look bad. Can you test with some other desktop themes?
  
  
  I would be in favor of more consistency wherever possible. However if we can't get that, I would still vote for having these changes applied to notifications rather than not have them because of inconsistencies elsewhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190108/408f90ba/attachment.html>