<table><tr><td style="">abetts added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17975">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D17975#388981" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17975#388981</a>, <a href="https://phabricator.kde.org/p/filipf/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@filipf</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I have some concerns about this. Mostly it's about visual consistency and notifications having different padding than other plasmoids. Notice how there's currently more or less equal distance to the left of Audio Volume and to the left of the album cover icon?</p>
<p><a href="https://phabricator.kde.org/F6535430" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6535430: Screenshot_20190108_133709.png</a></p>
<p>Wouldn't it be better to somehow add padding globally?</p>
<p>Plus, some desktop themes already add padding, which would make their notifications look bad. Can you test with some other desktop themes?</p></div>
</blockquote>
<p>I would be in favor of more consistency wherever possible. However if we can't get that, I would still vote for having these changes applied to notifications rather than not have them because of inconsistencies elsewhere.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17975">https://phabricator.kde.org/D17975</a></div></div><br /><div><strong>To: </strong>rooty, VDG, Plasma, ngraham<br /><strong>Cc: </strong>abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>