D17983: StatusItemNotifier: fix overlays by name with icons by name

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jan 7 15:33:57 GMT 2019


apol added a comment.


  +1
  Makes a lot of sense overall, I'd just like to make sure we're not missing something.

INLINE COMMENTS

> statusnotifieritemsource.cpp:296
>  
>                      if (overlayNames.isEmpty() && !overlay.isNull()) {
>                          overlayIcon(&icon, &overlay);

Can this bit be removed then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17983

To: pino
Cc: apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190107/71f29e20/attachment.html>


More information about the Plasma-devel mailing list