D17983: StatusItemNotifier: fix overlays by name with icons by name

[Pino Toscano]

pino created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pino requested review of this revision.

REVISION SUMMARY
  Setting an overlay by name results in a QIcon for it created; OTOH,
  this icon is never used to create the final image in case the
  main/attention icons are set by name too.
  
  Since KIconEngine supports overlays natively, directly pass the list of
  overlays (with just one element -- the overlay set) to it.  As result,
  main/attention icons by name are created directly with the requested
  overlay by name.

TEST PLAN
  - builds fine
  - main/attention icon by name + overlay by name works now, showing the requested overlay
  - main/attention icon by name + overlay by pixmap still works as before
  - main/attention icon by pixmap is unaffected, no matter whether/which overlay is set
  - the system tray icons of juk, and amarok now have the play/pause overlays

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sni-overlays (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17983

AFFECTED FILES
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: pino
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190105/237169f4/attachment.html>