D17975: [WIP, Notifications] Add padding to notifications

[Nathaniel Graham]

ngraham added a comment.


  A bit more padding is good!
  
  1. Making this pixel-perfect with every combination of font and font size is going to be impossible sadly. With that in mind, the most elegant design is one that makes this not a problem, because it doesn't have to be pixel-perfect and all the baselines are at least aligned.
  
  2. No matter what you pick here, it will look wrong in some cases. :(  If you anchor the icon to the top left, it will look bad the moment there's a second line of text. But if you vertically center it, then it looks bad anytime the notification is tall. Judgment call I think, but personally I'm in favor of anchoring it to the top left.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190105/2f6b169f/attachment.html>