D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Even when a user scours the system settings + desktop config looking how to disable this button, the user will have no indication this feature is called the "Desktop Toolbox". The button itself will show the current activity when not placed in a corner (eg: "Default" activity). When you click the menu, it does not have a "Desktop Toolbox" label either.
  
  -----
  
  So I suggest that we show the icon next to the checkbox. Here's what it looks like with all 4 combinations of Breeze Light/Dark Color Theme + Desktop Theme.
  
  F6521014: 2019-01-02___10-54-43.png <https://phabricator.kde.org/F6521014>
  
  F6521013: 2019-01-02___10-53-24.png <https://phabricator.kde.org/F6521013>
  
  F6521012: 2019-01-02___10-52-57.png <https://phabricator.kde.org/F6521012>
  
  F6521011: 2019-01-02___10-54-15.png <https://phabricator.kde.org/F6521011>

TEST PLAN
  - Copy `/usr/share/plasma/plasmoids/org.kde.desktopcontainment` to `~/.local/share/plasma/plasmoids/`
  - Edit `contents/ui/ConfigTweaks.qml`
  - Reopen the Desktop Settings > Tweaks (no restart of plasma is needed since the config window is destroyed and reloaded each time it's opened).
  - Delete `~/.local/share/plasma/plasmoids/org.kde.desktopcontainment/` when you're finished testing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17921

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: Zren
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190102/9683894a/attachment-0001.html>