D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox
Chris Holland
noreply at phabricator.kde.org
Thu Feb 28 22:02:26 GMT 2019
Zren added inline comments.
INLINE COMMENTS
> configAppearance.qml:137
> + icon.name: "preferences-desktop-locale"
> + onClicked: KCMShell.open("formats.desktop")
> + }
Was afk today sorry.
Do we need `visible: KCMShell.authorize("formats.desktop").length > 0` here? It hides the contextmenu item in `main.qml` if the user doesn't have permission.
https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/ui/main.qml#L109
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19230
To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190228/351cba86/attachment-0001.html>
More information about the Plasma-devel
mailing list