<table><tr><td style="">Zren added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19230">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19230#inline-108409">View Inline</a><span style="color: #4b4d51; font-weight: bold;">configAppearance.qml:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">icon.name:</span> <span style="color: #766510">"preferences-desktop-locale"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onClicked:</span> <span style="color: #004012">KCMShell</span><span class="p">.</span><span style="color: #004012">open</span><span class="p">(</span><span style="color: #766510">"formats.desktop"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Was afk today sorry.</p>
<p style="padding: 0; margin: 8px;">Do we need <tt style="background: #ebebeb; font-size: 13px;">visible: KCMShell.authorize("formats.desktop").length > 0</tt> here? It hides the contextmenu item in <tt style="background: #ebebeb; font-size: 13px;">main.qml</tt> if the user doesn't have permission.</p>
<p style="padding: 0; margin: 8px;"><a href="https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/ui/main.qml#L109" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/ui/main.qml#L109</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19230">https://phabricator.kde.org/D19230</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, Zren, VDG, davidedmundson, ndavis<br /><strong>Cc: </strong>cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>