D19340: Search new knsrc locations

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Feb 26 15:12:29 GMT 2019


apol added inline comments.

INLINE COMMENTS

> KNSBackend.cpp:69
> +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MAJOR>=56
> +            QStringList locations = KNSCore::Engine::configSearchLocations(true);
> +#else

Discover should probably not fallback, i.e. pass false as an argument.
Otherwise the problem will persist.

This is Plasma 5.16 and by then we should have all applications within KDE ported. This can be an incentive for the rest to install in the right place.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190226/6ba74929/attachment-0001.html>


More information about the Plasma-devel mailing list