D19214: [sddm-theme] WIP, Replace login button label with icon

[Nathaniel Graham]

ngraham added a comment.


  +1 for this design as well. It's much better-looking overall.
  
  If click targets are a potential problem for touch, my preference would be to make all of the textual elements larger, which would have the effect of scaling everything up--and also making the text more readable all over the place. Probably material for another patch though.

INLINE COMMENTS

> MainBlock.qml:100
>  
> -        text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Unlock")
> -        onClicked: startLogin()
> +            PlasmaCore.IconItem {
> +                    anchors.fill: parent

You don't need to add a separate `iconItem`; just give the button `iconSource: "configure"`

> Login.qml:109
> +
> +            PlasmaCore.IconItem {
> +                anchors.fill: parent

Ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190222/91c50901/attachment-0001.html>