D19194: Adjust date string height to match time string with vertical panel

Nathaniel Graham noreply at phabricator.kde.org
Thu Feb 21 14:14:25 GMT 2019


ngraham added subscribers: Zren, davidedmundson, ngraham.
ngraham added reviewers: Plasma, davidedmundson, Zren.
ngraham added a comment.


  Thank you for the patch! You did great, and on the first try, too!
  
  I can confirm that this change fixes the issue for me and I do not notice any visual regressions when using a horizontal or vertical panel, either with the default height, or a taller/wider height. The code change looks sane on the surface (more than sane even, since it's removing the use of a magic number), however I'm not super familiar with this code so I'd like @zren and/or @davidedmundson to sign off on this first.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren
Cc: ngraham, davidedmundson, Zren, abetts, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/11bc9c69/attachment.html>


More information about the Plasma-devel mailing list