<table><tr><td style="">ngraham added subscribers: Zren, davidedmundson, ngraham.<br />ngraham added reviewers: Plasma, davidedmundson, Zren.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19194">View Revision</a></tr></table><br /><div><div><p>Thank you for the patch! You did great, and on the first try, too!</p>
<p>I can confirm that this change fixes the issue for me and I do not notice any visual regressions when using a horizontal or vertical panel, either with the default height, or a taller/wider height. The code change looks sane on the surface (more than sane even, since it's removing the use of a magic number), however I'm not super familiar with this code so I'd like <a href="https://phabricator.kde.org/p/Zren/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@Zren</a> and/or <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> to sign off on this first.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19194">https://phabricator.kde.org/D19194</a></div></div><br /><div><strong>To: </strong>antnyzilla, VDG, Plasma, davidedmundson, Zren<br /><strong>Cc: </strong>ngraham, davidedmundson, Zren, abetts, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>