D19077: Redesign the theme preview window

[Krešimir Čohar]

rooty added a comment.


  In D19077#416427 <https://phabricator.kde.org/D19077#416427>, @filipf wrote:
  
  > @davidedmundson yes, so without the hack I get this happening:
  >
  > F6627430: image.png <https://phabricator.kde.org/F6627430>
  >
  > When using childrenRect, I believe the rectangle's height is properly adjusted for the **tallest** theme preview, but ends up being too short for the other ones, thereby exposing the white-backgrounded QQuickWidget that contains this QML file.
  >
  > The hack unfortunately throws the root Rectangle's height property in a binding loop, but seems to be effective in both adjusting the height and not having the underlying widget exposed.
  
  
  If I remove that extra rectangle (the hack) and add one unit of largeSpacing to line 24, everything works both on Arch and on Neon
  F6627438: image.png <https://phabricator.kde.org/F6627438> 
  (I changed the layout of Background to accommodate the qml label margins, still working on the wallpaper button tho)

INLINE COMMENTS

> davidedmundson wrote in main.qml:39
> can you explain this?
> 
> It's the size of root and the same colour

i removed this extra rectangle and added large.Spacing to the height at line 24 and everything works fine both on my arch rig and on neon?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/09927427/attachment.html>