D19077: Redesign the theme preview window

Filip Fila noreply at phabricator.kde.org
Thu Feb 21 00:33:22 GMT 2019


filipf added a comment.


  @davidedmundson yes, so without the hack I get this happening:
  
  F6627430: image.png <https://phabricator.kde.org/F6627430>
  
  When using childrenRect, I believe the rectangle's height is properly adjusted for the **tallest** theme preview, but ends up being too short for the other ones, thereby exposing the white-backgrounded QQuickWidget that contains this QML file.
  
  The hack unfortunately throws the root Rectangle's height property in a binding loop, but seems to be effective in both adjusting the height and not having the underlying widget exposed.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/c99148c7/attachment-0001.html>


More information about the Plasma-devel mailing list