D19079: Make look of Font Management KCM UI more consistent

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> KCmFontInst.cpp:236
> +    itsDeleteGroupControl=new CPushButton(KGuiItem(QString(), "list-remove",
> +                                                   i18n("Remove Group...")),
>                                            groupWidget);

This one doesn't need an ellipsis. If the window/dialog that pops up when you click on it is nothing more than a confirmation box, we don't use ellipsis.

However the confirmation dialog that results from clicking on this could use better icons in its buttons for sure.

> KCmFontInst.cpp:240
>      itsEnableGroupControl=new CPushButton(KGuiItem(QString(), "enablefont",
> -                                                   i18n("Enable all disabled fonts in the current group")),
> +                                                   i18n("Enable Fonts in Group...")),
>                                            groupWidget);

Same: no ellipsis when the "additional user input required" is just a confirmation dialog (and do we even need this confirmation dialog anyway???).

> KCmFontInst.cpp:244
>      itsDisableGroupControl=new CPushButton(KGuiItem(QString(), "disablefont",
> -                                                    i18n("Disable all enabled fonts in the current group")),
> +                                                    i18n("Disable Fonts in Group...")),
>                                             groupWidget);

Same

> KCmFontInst.cpp:295
> +    itsDeleteFontControl=new CPushButton(KGuiItem(QString(), "edit-delete",
> +                                                  i18n("Delete Selected Fonts...")),
>                                           fontControlWidget);

Same

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19079

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190216/ad69cc92/attachment-0001.html>