<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19079">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19079#inline-106212">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KCmFontInst.cpp:236</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">itsDeleteGroupControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span style="color: #766510">"<span class="bright">edit-delet</span>e"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Remove <span class="bright">g</span>roup"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">itsDeleteGroupControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span style="color: #766510">"<span class="bright">list-remov</span>e"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Remove <span class="bright">G</span>roup<span class="bright">...</span>"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">groupWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This one doesn't need an ellipsis. If the window/dialog that pops up when you click on it is nothing more than a confirmation box, we don't use ellipsis.</p>
<p style="padding: 0; margin: 8px;">However the confirmation dialog that results from clicking on this could use better icons in its buttons for sure.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19079#inline-106214">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KCmFontInst.cpp:240</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">itsEnableGroupControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span style="color: #766510">"enablefont"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Enable <span class="bright">all disabled f</span>onts in <span class="bright">the current g</span>roup"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Enable <span class="bright">F</span>onts in <span class="bright">G</span>roup<span class="bright">...</span>"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">groupWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same: no ellipsis when the "additional user input required" is just a confirmation dialog (and do we even need this confirmation dialog anyway???).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19079#inline-106215">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KCmFontInst.cpp:244</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">itsDisableGroupControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span style="color: #766510">"disablefont"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Disable <span class="bright">all enabled f</span>onts in <span class="bright">the current g</span>roup"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Disable <span class="bright">F</span>onts in <span class="bright">G</span>roup<span class="bright">...</span>"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">groupWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19079#inline-106216">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KCmFontInst.cpp:295</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">itsDeleteFontControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Delete"</span></span><span class="p">),</span> <span style="color: #766510">"edit-delete"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Delete <span class="bright">all s</span>elected <span class="bright">f</span>onts"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">itsDeleteFontControl</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">CPushButton</span><span class="p">(</span><span class="n">KGuiItem</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>),</span> <span style="color: #766510">"edit-delete"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Delete <span class="bright">S</span>elected <span class="bright">F</span>onts<span class="bright">...</span>"</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">fontControlWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19079">https://phabricator.kde.org/D19079</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, ngraham<br /><strong>Cc: </strong>ngraham, VDG, plasma-devel, Plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>