D19044: [InlineMessage] Do not draw shadows around the message

Filip Fila noreply at phabricator.kde.org
Fri Feb 15 17:07:25 GMT 2019


filipf created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch removes InlineMessage's DropShadow for the following reasons:
  
  1. consistency - there are no shadows in QWidgets' inline messages
  2. visual hierarchy - shadows add depth, making the message seem like it
  
  is floating over the window's conten and thereby also making the message
  seem fairly prominent
  
  3. aesthethics - no shadows means a cleaner look

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19044

AFFECTED FILES
  src/controls/InlineMessage.qml

To: filipf
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190215/74773562/attachment.html>


More information about the Plasma-devel mailing list