<table><tr><td style="">filipf created this revision.<br />Herald added a project: Kirigami.<br />Herald added a subscriber: plasma-devel.<br />filipf requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19044">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This patch removes InlineMessage's DropShadow for the following reasons:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">consistency - there are no shadows in QWidgets' inline messages</li>
<li class="remarkup-list-item">visual hierarchy - shadows add depth, making the message seem like it</li>
</ol>
<p>is floating over the window's conten and thereby also making the message<br />
seem fairly prominent</p>
<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">aesthethics - no shadows means a cleaner look</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19044">https://phabricator.kde.org/D19044</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/controls/InlineMessage.qml</div></div></div><br /><div><strong>To: </strong>filipf<br /><strong>Cc: </strong>plasma-devel, dkardarakos, apol, davidedmundson, mart, hein<br /></div>