D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi please do me a favour:
  
  1. close this review and open a clean new one because for some reason when trying to test it in my system includes also one old commit that I added the ViewType option
  2. no problem with & characters you can add them
  3. no problem to hide the Dock/Panel View when (configuring)
  4. please dont use the config file to access the viewType, I found an alternative way that it is in the master, we sniff now the viewType through dbus contextMenuData. The menu sends the containment->id() and when contextMenuData are requested these data include also the view type.
  5. For the setVisible(true) and how this bug occurs we will discuss it again at the new review

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/06c45808/attachment-0001.html>