D18918: Make the text of "View Settings" action more specific

Tranter Madi noreply at phabricator.kde.org
Tue Feb 12 17:08:31 GMT 2019


trmdi added inline comments.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:92
> in this slot is also needed:
> 
>   m_configureAction->setEnabled(true);
> 
> there are cases that the Dock Settings is shown when !configuring but it is not enabled

I don't understand. my code only change the `visible` property, why does it have to handle the "enable" one?

You meant the setting is showing but configuring==false? Sound weird. How to make it happen?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/6e7e8860/attachment-0001.html>


More information about the Plasma-devel mailing list