D18918: Make the text of "View Settings" action more specific

Tranter Madi noreply at phabricator.kde.org
Tue Feb 12 16:03:40 GMT 2019


trmdi added inline comments.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:91
> is this still needed if we check the value each time we show up the context menu?

Yes, it's needed. Because when you're opening the Setting window and you right click on the view, it will close the Setting window, not a nice behavior. So we should hide it when the Setting window is opening.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/dfe4b57a/attachment.html>


More information about the Plasma-devel mailing list