D18717: improvements for global shortcuts

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi can you confirm me the following for your code ?
  
  1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded
  2. When the user changed the isPreferredForShortcuts for first time afterwards [1] is never used again EXCEPT if the user set the property
  
    preferredForShortcutsTouched=false
  
  on its own
  
  Is this what you wanted to achieve?
  
  Note: this is important, the preferredForShortcutsTouched property must be moved from universalsettings to layout

INLINE COMMENTS

> universalsettings.h:51
>      Q_PROPERTY(bool showInfoWindow READ showInfoWindow WRITE setShowInfoWindow NOTIFY showInfoWindowChanged)
> +    Q_PROPERTY(bool preferredForShortcutsTouched READ preferredForShortcutsTouched WRITE setPreferredForShortcutsTouched NOTIFY preferredForShortcutsTouchedChanged)
>  

this needs to be part of layout.h because it should be set at per layout level if it is set at universalsettings then many things could break when the user switches layouts or uses MultipleLayouts

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18717

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190204/15d74eb6/attachment-0001.html>