<table><tr><td style="">mvourlakos added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18717">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/trmdi/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@trmdi</a> can you confirm me the following for your code ?</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded</li>
<li class="remarkup-list-item">When the user changed the isPreferredForShortcuts for first time afterwards [1] is never used again EXCEPT if the user set the property</li>
</ol>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">preferredForShortcutsTouched=false</pre></div>
<p>on its own</p>
<p>Is this what you wanted to achieve?</p>
<p>Note: this is important, the preferredForShortcutsTouched property must be moved from universalsettings to layout</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18717#inline-103930">View Inline</a><span style="color: #4b4d51; font-weight: bold;">universalsettings.h:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">showInfoWindow</span> <span class="n">READ</span> <span class="n">showInfoWindow</span> <span class="n">WRITE</span> <span class="n">setShowInfoWindow</span> <span class="n">NOTIFY</span> <span class="n">showInfoWindowChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">preferredForShortcutsTouched</span> <span class="n">READ</span> <span class="n">preferredForShortcutsTouched</span> <span class="n">WRITE</span> <span class="n">setPreferredForShortcutsTouched</span> <span class="n">NOTIFY</span> <span class="n">preferredForShortcutsTouchedChanged</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this needs to be part of layout.h because it should be set at per layout level if it is set at universalsettings then many things could break when the user switches layouts or uses MultipleLayouts</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R878 Latte Dock</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18717">https://phabricator.kde.org/D18717</a></div></div><br /><div><strong>To: </strong>trmdi, mvourlakos<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>