D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

Ronnie Thomas noreply at phabricator.kde.org
Sun Feb 3 14:59:00 GMT 2019


rthomas updated this revision to Diff 50771.
rthomas added a reviewer: Plasma.
rthomas added a comment.


  Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth.
  
  Reason for choosing those 4 devices is those are the only devices we set icons for (according to my understanding).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18689?vs=50752&id=50771

REVISION DETAIL
  https://phabricator.kde.org/D18689

AFFECTED FILES
  libs/declarative/connectionicon.cpp

To: rthomas, jgrulich, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190203/4b4f252a/attachment.html>


More information about the Plasma-devel mailing list