<table><tr><td style="">rthomas updated this revision to Diff 50771.<br />rthomas added a reviewer: Plasma.<br />rthomas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18689">View Revision</a></tr></table><br /><div><div><p>Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth.</p>
<p>Reason for choosing those 4 devices is those are the only devices we set icons for (according to my understanding).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D18689?vs=50752&id=50771">https://phabricator.kde.org/D18689?vs=50752&id=50771</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18689">https://phabricator.kde.org/D18689</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libs/declarative/connectionicon.cpp</div></div></div><br /><div><strong>To: </strong>rthomas, jgrulich, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>