D18640: Reset tooltip delegate label height to defaults

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Feb 1 08:42:06 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It seems Qt 5.12 changed the behavior of `contentHeight` to not include any font padding.
  
  BUG: 401842
  FIXED-IN: 5.15.0

TEST PLAN
  Please someone test with Qt 5.11
  The width is kept as otherwise the tooltip doesn't resize properly for some reason.
  assigning `undefined` to `height` resets it to `implicitHeight` which includes some padding but not the huge padding Plasma's `Label` has (which was the main reason for setting `contentHeight` in the first place)
  
  Before
  F6580728: Screenshot_20190201_094149.png <https://phabricator.kde.org/F6580728>
  After
  F6580729: Screenshot_20190201_094128.png <https://phabricator.kde.org/F6580729>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18640

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190201/27029141/attachment.html>


More information about the Plasma-devel mailing list