<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, VDG.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18640">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>It seems Qt 5.12 changed the behavior of <tt style="background: #ebebeb; font-size: 13px;">contentHeight</tt> to not include any font padding.</p>
<p>BUG: 401842<br />
FIXED-IN: 5.15.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Please someone test with Qt 5.11<br />
The width is kept as otherwise the tooltip doesn't resize properly for some reason.<br />
assigning <tt style="background: #ebebeb; font-size: 13px;">undefined</tt> to <tt style="background: #ebebeb; font-size: 13px;">height</tt> resets it to <tt style="background: #ebebeb; font-size: 13px;">implicitHeight</tt> which includes some padding but not the huge padding Plasma's <tt style="background: #ebebeb; font-size: 13px;">Label</tt> has (which was the main reason for setting <tt style="background: #ebebeb; font-size: 13px;">contentHeight</tt> in the first place)</p>
<p>Before<br />
<a href="https://phabricator.kde.org/F6580728" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6580728: Screenshot_20190201_094149.png</a><br />
After<br />
<a href="https://phabricator.kde.org/F6580729" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6580729: Screenshot_20190201_094128.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18640">https://phabricator.kde.org/D18640</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kicker/package/contents/ui/main.qml<br />
containments/desktop/package/contents/ui/AppletHandle.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>