D18621: Add again a button to manually scan for wireless networks

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Feb 1 07:59:20 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> Toolbar.qml:116
> +        id: wifiRefreshButton
> +        enabled: false
> +

I would do it declaratively:

  enabled: !coolDownTimer.running

> Toolbar.qml:124
> +
> +        tooltip: i18ndc("plasma-nm", "button tooltip", "Scan for new wireless networks")
> +        iconSource: "view-refresh"

Why does this need an explicit domain?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: broulik, davidedmundson, alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190201/28f7ec54/attachment-0001.html>


More information about the Plasma-devel mailing list