D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> manager.cpp:419
>  
>  void Manager::showLatteSettingsDialog(int page)
>  {

We could try to rename the function to:

  void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = false)

when cycleBetweenPages = true then the current behavior is applied, in any other case the specified firstPage is shown

> settingsdialog.cpp:365
>  
> -void SettingsDialog::toggleCurrentPage()
> +void SettingsDialog::toggleCurrentPage(int page)
>  {

leave this function untouched and introduce a new function called,

  setCurrentPage(int page)

> settingsdialog.h:58
>  
> -    void toggleCurrentPage();
> +    void toggleCurrentPage(int page);
>  

leave this function untouched and introduce a new function called,

setCurrentPage(int page)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191227/ea6e0f5a/attachment.html>