D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

George Vogiatzis noreply at phabricator.kde.org
Thu Dec 26 13:35:10 GMT 2019


gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Unify 'raise maximum volume' menu option and 'maximum volume' configuration setting.
  
  Make default 'maximum volume' 150.
  For volume control check 'raise maximum volume' option, to use 'maximum volume'.
  Volume slider use 'maximum volume', if 'raise maximum volume' is enabled.
  
  BUG: 385041
  FIXED-IN: 5.18.0
  Depends on D26212 <https://phabricator.kde.org/D26212>

TEST PLAN
  Before:
  Volume control from shortcuts will use 'maximum volume' for all devices.
  Slider will set maximum range 150 for 'raise maximum volume' option.
  After:
  'Raise maximum volume' respects 'maximum volume' and,
  'maximum volume' does not work without 'Raise maximum volume'.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  max4

REVISION DETAIL
  https://phabricator.kde.org/D26234

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191226/84ee44ee/attachment.html>


More information about the Plasma-devel mailing list