D26086: Don't fetch pixmap if we have it already

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Dec 18 15:15:09 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `AppData` contains a `QIcon` with pixmap data gathered from `KWindowSystem::icon` which we can just use.
  Only if, for some reason, the icon is really null, try getting it from `KWindowSystem` on demand.

TEST PLAN
  Pinned my xcalc to the task bar, got the same pixmap serialized as before, without a roundtrip to the x server

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26086

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191218/f6916c27/attachment-0001.html>


More information about the Plasma-devel mailing list