<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, hein.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26086">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><tt style="background: #ebebeb; font-size: 13px;">AppData</tt> contains a <tt style="background: #ebebeb; font-size: 13px;">QIcon</tt> with pixmap data gathered from <tt style="background: #ebebeb; font-size: 13px;">KWindowSystem::icon</tt> which we can just use.<br />
Only if, for some reason, the icon is really null, try getting it from <tt style="background: #ebebeb; font-size: 13px;">KWindowSystem</tt> on demand.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Pinned my xcalc to the task bar, got the same pixmap serialized as before, without a roundtrip to the x server</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26086">https://phabricator.kde.org/D26086</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libtaskmanager/xwindowtasksmodel.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>