D26035: battery: Improve the brightness responsiveness

[Kai Uwe Broulik]

broulik added a comment.


  `PlasmaComponents` 3 `Slider` doesn't react to wheel events, which must be fixed before this can go in.

INLINE COMMENTS

> PopupDialog.qml:48
> -
> -        keyboardBrightnessSlider.valueChanged.connect(function() {
> -            batterymonitor.keyboardBrightness = keyboardBrightnessSlider.value

What about this?

> batterymonitor.qml:109
> +    property QtObject updateScreenBrightnessJob
>      onScreenBrightnessChanged: {
>          if (disableBrightnessUpdate) {

Should we not forward the notion of "moved" here, too?

> logic.js:53
>  function updateBrightness(rootItem, source) {
> +    if (rootItem.updateScreenBrightnessJob || rootItem.updateKeyboardBrightnessJob)
> +        return;

Wouldn't that cause subsequent calls to fail if the previous hasn't finished yet? Wouldn't that be annoying if you drag the slider quickly?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26035

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191216/a5ab0371/attachment.html>