D26035: battery: Improve the brightness responsiveness

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Dec 16 01:14:07 GMT 2019


apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Use QQC2.Slider, so that we have a moved signal. This way we can only
  issue new brightnesses when the user actually interacts with it.
  Don't adapt to the system brightness until we have finished interacting
  with it.

TEST PLAN
  Manual testing, flickering is very much reduced both when scrolling over the
  compact plasmoid as well as the slider.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26035

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js
  dataengines/powermanagement/powermanagementjob.cpp
  dataengines/powermanagement/powermanagementjob.h

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191216/0f82878e/attachment.html>


More information about the Plasma-devel mailing list