D25846: [Cuttlefish] Use the same actions in all menus

[Nathaniel Graham]

ngraham added a comment.


  Nice, a very good refactor.

INLINE COMMENTS

> Menu.qml:24
>  
> -import QtQuick 2.5
> -import Qt.labs.platform 1.0
> +import QtQuick 2.3
> +import QtQuick.Controls 2.5 as QQC2

unrelated

> Menu.qml:47
> +            property Component submenuComponent: actionsMenu
> +            //renamed to work on both Qt 5.9 and 5.10
> +            property Component itemDelegate: QQC2.MenuItem { }

Do we need to care about those? Plasma's minimum Qt version is 5.12 right now.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25846

To: davidre, #plasma, ngraham, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191210/36506862/attachment.html>