D25846: [Cuttlefish] Use the same actions in all menus
David Redondo
noreply at phabricator.kde.org
Tue Dec 10 14:20:25 GMT 2019
davidre created this revision.
davidre added reviewers: Plasma, ngraham, cblack.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.
REVISION SUMMARY
Defines the actions in one place and uses them for the context menus and
buttons in the two preview panes. This reduces code duplication, adds
actions to the context menu which couldn't be triggered from there before
and makes it easier to add new features with only needing to touch one place
instead of potentially three. Furthermore this also reduces the risk of bugs
caused by copy-pasting, for example the screenshot actions didn't work before
in responsive mode.
The actionsMenu component is based on the one from Kirigami with the same name.
TEST PLAN
Everything works
REPOSITORY
R118 Plasma SDK
BRANCH
actions (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25846
AFFECTED FILES
cuttlefish/package/contents/ui/Actions.qml
cuttlefish/package/contents/ui/Menu.qml
cuttlefish/package/contents/ui/Preview.qml
cuttlefish/package/contents/ui/ResponsivePreview.qml
cuttlefish/package/contents/ui/cuttlefish.qml
To: davidre, #plasma, ngraham, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191210/5cb12c05/attachment.html>
More information about the Plasma-devel
mailing list