D23567: [Colors KCM] Don't explicitly reload KWin's configuration
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Aug 29 14:33:54 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
KWin watches decoration palette changes on its own.
When Plasma changes its colorscheme it will send new background contrast information to KWin anyway.
plasma-integration listens to color scheme changes and updates the `QApplication` palette,
TEST PLAN
This code has been in there for over a decade, likely having been neccessary before KDecoration2 was around?
Changed color scheme:
- No longer have KWin re-initalize its compositor, the overall color scheme change feels a lot less jarring now
- Decoration color updates immediately
- Context menu on decoration updates immediately
- Tabbox stuff updates immediately (plasma theme)
- The panel flickers funnily during the change but that might have just previously been covered by the fact that KWin drops some frames while reinitializing the compositor?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D23567
AFFECTED FILES
kcms/colors/colors.cpp
To: broulik, #plasma, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190829/43fd15d9/attachment-0001.html>
More information about the Plasma-devel
mailing list