D23520: Add time line to X axis

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  Only showing the date once per day is clever, but it can be even more clever: when all of the times in the graph correspond to the current day, there's no need to show it at all. You can see this issue in this screenshot:
  F7289397: Screenshot_20190828_120513.png <https://phabricator.kde.org/F7289397>
  
  As you can see, it's kind of funny that only one of the labels has a date under it. This is fine for the multi-day graphs, but for the graphs that are entirely within the current day, I would recommend omitting the date.
  
  Code-wise, there are some formatting issues:
  
  - Don't add semicolons
  - Use 4 spaces for indentation
  - Clean up indentation and make it consistent
  - Add spaces between operators (e.g. `diff / 1000`)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190828/7c72f855/attachment.html>